Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[home][ncl] fix loading or exporting bundles #22841

Merged
merged 2 commits into from
Jun 12, 2023
Merged

[home][ncl] fix loading or exporting bundles #22841

merged 2 commits into from
Jun 12, 2023

Conversation

Kudo
Copy link
Contributor

@Kudo Kudo commented Jun 12, 2023

Why

fix the following errors when publishing dev home

Error: Cannot find module '/Users/kudo/expo/expo/react-native-lab/react-native/rn-get-polyfills'
Require stack:
- /Users/kudo/expo/expo/home/metro.config.js
- /Users/kudo/expo/expo/node_modules/cosmiconfig/node_modules/import-fresh/index.js
- /Users/kudo/expo/expo/node_modules/cosmiconfig/dist/loaders.js
- /Users/kudo/expo/expo/node_modules/cosmiconfig/dist/createExplorer.js
- /Users/kudo/expo/expo/node_modules/cosmiconfig/dist/index.js
- /Users/kudo/expo/expo/node_modules/metro-config/src/loadConfig.js
- /Users/kudo/expo/expo/node_modules/metro-config/src/index.js
- /Users/kudo/expo/expo/node_modules/metro/src/commands/build.js
- /Users/kudo/expo/expo/node_modules/metro/src/index.flow.js
- /Users/kudo/expo/expo/node_modules/metro/src/index.js
- /Users/kudo/expo/expo/packages/@expo/dev-server/build/metro/importMetroFromProject.js
- /Users/kudo/expo/expo/packages/@expo/cli/build/src/export/fork-bundleAsync.js
- /Users/kudo/expo/expo/packages/@expo/cli/build/src/export/createBundles.js
- /Users/kudo/expo/expo/packages/@expo/cli/build/src/export/exportApp.js
- /Users/kudo/expo/expo/packages/@expo/cli/build/src/export/exportAsync.js
- /Users/kudo/expo/expo/packages/@expo/cli/build/src/export/index.js
- /Users/kudo/expo/expo/packages/@expo/cli/build/bin/cli

How

  • since the react-native monorepo changes, we should use the react-native-lab/react-native/packages/react-native as root.
  • republish dev home

Test Plan

  • unversioned expo go + ncl

Checklist

@expo-bot expo-bot added the bot: passed checks ExpoBot has nothing to complain about label Jun 12, 2023
@Kudo Kudo marked this pull request as ready for review June 12, 2023 13:03
@Kudo Kudo requested a review from tsapeta June 12, 2023 13:03
Copy link
Member

@tsapeta tsapeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💛

@Kudo Kudo merged commit 1395b1a into main Jun 12, 2023
@Kudo Kudo deleted the @kudo/fix-home branch June 12, 2023 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants