Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[android][ios] Upgrade @react-native-community/datetimepicker to 7.2.0 #23034

Merged
merged 1 commit into from
Jun 22, 2023
Merged

[android][ios] Upgrade @react-native-community/datetimepicker to 7.2.0 #23034

merged 1 commit into from
Jun 22, 2023

Conversation

gabrieldonadel
Copy link
Member

@gabrieldonadel gabrieldonadel commented Jun 22, 2023 •
edited
Loading

Why

Upgrades @react-native-community/datetimepicker to 7.2.0

How

et uvm -m @react-native-community/datetimepicker -c "v7.2.0"
yarn 
et pods -f

Test Plan

  • test using bare-expo Android + NCL DateTimePicker Example
  • test using bare-expo iOS + NCL DateTimePickerExample
  • test unversioned expo go ios + NCL DateTimePicker Example
  • test unversioned expo go android + NCL DateTimePicker Example

Checklist

@expo-bot expo-bot added the bot: passed checks ExpoBot has nothing to complain about label Jun 22, 2023
Kudo
Kudo approved these changes Jun 22, 2023
View reviewed changes
Copy link
Contributor

@Kudo Kudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

previewing the PR and looks good to me without native changes but only version bump 😂

tsapeta
tsapeta reviewed Jun 22, 2023
View reviewed changes
Copy link
Member

@tsapeta tsapeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you need to rebase with main and reinstall pods, the Podfile.lock has a lot of different hashes 😉

@gabrieldonadel gabrieldonadel marked this pull request as ready for review June 22, 2023 15:40
@gabrieldonadel gabrieldonadel force-pushed the @gabrieldonadel/update-@react-native-community/datetimepicker-7.2.0 branch from ddd8246 to 51e0f3b Compare June 22, 2023 15:40
@gabrieldonadel gabrieldonadel requested a review from tsapeta June 22, 2023 15:40
@gabrieldonadel gabrieldonadel force-pushed the @gabrieldonadel/update-@react-native-community/datetimepicker-7.2.0 branch from 51e0f3b to 8d880e4 Compare June 22, 2023 17:10
@gabrieldonadel gabrieldonadel merged commit 3ad86d0 into main Jun 22, 2023
@gabrieldonadel gabrieldonadel deleted the @gabrieldonadel/update-@react-native-community/datetimepicker-7.2.0 branch June 22, 2023 21:02
This was referenced Jun 24, 2023
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsapeta tsapeta tsapeta approved these changes

@Kudo Kudo Kudo approved these changes

@ide ide Awaiting requested review from ide

@brentvatne brentvatne Awaiting requested review from brentvatne

Assignees
No one assigned
Labels
bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gabrieldonadel @Kudo @tsapeta @expo-bot