-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[android][brightness] Fix: add event to module definition #24942
Conversation
class BrightnessModule : Module() { | ||
private val currentActivity | ||
get() = appContext.currentActivity ?: throw Exceptions.MissingActivity() | ||
|
||
override fun definition() = ModuleDefinition { | ||
Name("ExpoBrightness") | ||
|
||
Events(brightnessChangeEvent) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as #24943 (comment)
I belive this also happens in the ex-av module. If i edit the logline to include the |
Why
Same as #24943
How
This module has an event that is only supported on
iOS
but it still needs to be added to the module definition onAndroid
to prevent a warning.Test Plan
bare-expo. The warning is cleared