-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] fix splash flickering in dark mode #26015
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
expo-bot
added
bot: passed checks
ExpoBot has nothing to complain about
and removed
bot: suggestions
ExpoBot has some suggestions
labels
Dec 19, 2023
lukmccall
approved these changes
Dec 19, 2023
tsapeta
approved these changes
Dec 19, 2023
3 tasks
brentvatne
pushed a commit
that referenced
this pull request
Dec 19, 2023
# Why #26015 breaks the build on tvos: https://expo.dev/accounts/expo-ci/projects/updates-e2e/builds/a2f1abba-1712-4121-a6b0-d69c179d00a4 # How only set systemBackgroundColor on non-tvos # Test Plan ci passed: https://expo.dev/accounts/expo-ci/projects/updates-e2e/builds/2f54cf61-ae0d-4890-a7e7-64d907ae10e1 # Checklist - [x] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [x] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [x] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin).
brentvatne
pushed a commit
that referenced
this pull request
Dec 19, 2023
# Why #26015 breaks the build on tvos: https://expo.dev/accounts/expo-ci/projects/updates-e2e/builds/a2f1abba-1712-4121-a6b0-d69c179d00a4 # How only set systemBackgroundColor on non-tvos # Test Plan ci passed: https://expo.dev/accounts/expo-ci/projects/updates-e2e/builds/2f54cf61-ae0d-4890-a7e7-64d907ae10e1 # Checklist - [x] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [x] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [x] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin).
onizam95
pushed a commit
to onizam95/expo-av-drm
that referenced
this pull request
Jan 15, 2024
# Why aside from expo#25946 and expo#25971, i also noticed a splash flickering without expo-system-ui. this one is coming from RCTRootView setup. # How we didn't setup backgroundColor [as react-native](https://github.com/facebook/reactnative/blob/43826facfab8eed7d01a801778d1c477e60730a6/packages/react-native/Libraries/AppDelegate/RCTAppDelegate.mm#L154). in dark mode after splash screen and before App fully loaded, it will show white screen in between. this pr tries to set the RCTRootView's background color as system background color. - Note that with expo-system-ui, it may override the RCTRootView's background color from it's OnCreate lifecycle. - The downside of this pr's approach is that, ReactDelegate subscribers have no way to change the background color. i think it is okay if we don't support the use case.
onizam95
pushed a commit
to onizam95/expo-av-drm
that referenced
this pull request
Jan 15, 2024
# Why expo#26015 breaks the build on tvos: https://expo.dev/accounts/expo-ci/projects/updates-e2e/builds/a2f1abba-1712-4121-a6b0-d69c179d00a4 # How only set systemBackgroundColor on non-tvos # Test Plan ci passed: https://expo.dev/accounts/expo-ci/projects/updates-e2e/builds/2f54cf61-ae0d-4890-a7e7-64d907ae10e1 # Checklist - [x] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [x] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [x] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bot: fingerprint changed
bot: passed checks
ExpoBot has nothing to complain about
published
Changes from the PR have been published to npm
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
aside from #25946 and #25971, i also noticed a splash flickering without expo-system-ui. this one is coming from
RCTRootView setup.
How
we didn't setup backgroundColor as react-native. in dark mode after splash screen and before App fully loaded, it will show white screen in between. this pr tries to set the RCTRootView's background color as system background color.
Test Plan
as #25971
Checklist
npx expo prebuild
& EAS Build (eg: updated a module plugin).