-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[asset] Add config plugin to link assets to native project #27052
Conversation
3527e89
to
a4a47d0
Compare
@tsapeta @wschurman - Spoke with @brentvatne and we are going to exclude fonts from this because |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel pretty strongly that we shouldn't do that any
cast, especially because it's in first-party code and now there are multiple places that do it. I think if you want to fix it in a follow-up PR though, that's fine.
Added dotLottie files to the supported extensions. Also, used Doug's suggestion for the |
Why
Closes ENG-11315
How
Added a config plugin to
expo-asset
that allows adding assets to the native project.Supports
json, png, jpg, mp3, mp4, off, ttf, db, gif, lottie
.Test Plan
Created a test project and added various asset types. Some of our libraries currently don't support reading from the native project.
expo-av
: iOS onlyexpo-image
: iOS onlyexpo-sqlite
: iOS and androidI'll work on these in separate PRs