[media-library]: include more error information in native rejections #30504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The Pull Request introduced fingerprint changes against the base commit: 7c66ec3 Fingerprint diff[
{
"op": "changed",
"source": {
"type": "dir",
"filePath": "../../packages/expo-media-library/ios",
"reasons": [
"expoAutolinkingIos"
],
"hash": "b8a18d9dfba4a6695c0e67b3defb9f41b78c8fc9"
}
}
]Generated by PR labeler 🤖 |
vonovak
commented
Jul 18, 2024
| @@ -55,7 +55,7 @@ func stringifyAlbumType(type: PHAssetCollectionType) -> String { | |||
|
|
|||
| func exportAssetInfo(asset: PHAsset) -> [String: Any?]? { | |||
| if var assetDict = exportAsset(asset: asset) { | |||
| assetDict["location"] = exportLocation(location: asset.location) | |||
| assetDict["location"] = exportLocation(location: asset.location) ?? NSNull() | |||
There was a problem hiding this comment.
this assertion was failing - the location entry wasn't present in the response. now it's null.
Maybe we should rewrite this to use expo module Records?
alanjhughes
approved these changes
Jul 25, 2024
| @@ -218,7 +218,7 @@ func exportCollection(_ collection: PHAssetCollection?, folderName: String? = ni | |||
| "assetCount": assetCountOfCollection(collection), | |||
| "startTime": exportDate(collection.startDate), | |||
| "endTime": exportDate(collection.endDate), | |||
| "approximateLocation": exportLocation(location: collection.approximateLocation), | |||
| "approximateLocation": exportLocation(location: collection.approximateLocation) ?? NSNull(), | |||
There was a problem hiding this comment.
Suggested change
| "approximateLocation": exportLocation(location: collection.approximateLocation) ?? NSNull(), | |
| "approximateLocation": exportLocation(location: collection.approximateLocation) ?? nil, |
Any reason we wouldn't use nil here?
behenate
approved these changes
Jul 25, 2024
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
expo-bot
added
bot: passed checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
closes #30441
How
the native module rejections include the error message from the native error
Test Plan
#30441 mentions issues with deleting assets. Unfortunately I wasn't able to get the delete method to report an error (I tried deleting already deleted asset, or provide invalid data), but since it compiles and tests in bare expo pass I believe it's safe.
Checklist
npx expo prebuild& EAS Build (eg: updated a module plugin).