[media-library][android] Fix exceptions when moving or deleting video assets #31424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
behenate
force-pushed
the
@behenate/media-library/fix-move-and-delete
branch
from
56eae38 to
d58aec6
Compare
expo-bot
added
bot: passed checks
|
The Pull Request introduced fingerprint changes against the base commit: f55df2c Fingerprint diff[
{
"op": "changed",
"source": {
"type": "dir",
"filePath": "../../packages/expo-media-library/android",
"reasons": [
"expoAutolinkingAndroid"
],
"hash": "57909fb2370927a077f4e7e2c264fbb6c1313c73"
}
}
]Generated by PR labeler 🤖 |
behenate
force-pushed
the
@behenate/media-library/fix-move-and-delete
branch
from
d58aec6 to
4c9e8b3
Compare
lukmccall
approved these changes
Sep 12, 2024
|
Is it possible to have an ETA on when this could be merge? |
alanjhughes
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Fixes #31358
How
In the move strategy and delete we need to handle video types separately as images and videos are stored in different tables in the MediaStore database
Test Plan
Tested in BareExpo on Android SDK 34