[expo-av] Improve error-messages on iOS #9618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Native Component List for this branch is ready |
bbarthec
approved these changes
Aug 10, 2020
IjzerenHein
force-pushed
the
@hein/expo-av/error-logging
branch
from
7d8b2ed to
0a60f71
Compare
Jamedjo
pushed a commit
to Jamedjo/expo
that referenced
this pull request
Feb 4, 2021
* [expo-av] Improve error-messages on iOS * [expo-av] Update changelog * [expo-av] Improve error messages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Not all errors are logged with the actual reason; which makes it more difficult to find the cause.
E.g, when
Sound.preparefails because the app is in the background, this is logged:prepare encountered an error: audio session not activated!Which does not include the reason, which is that the app is in the background.
Related to #6294
How
Test Plan