[menu-bar] Add alert when trying to install build with no available d…

…evices (#38) * [menu-bar] Add alert when trying to install build with no available devices * Add changelog entry
expo · Aug 13, 2023 · 18a388c · 18a388c
1 parent fc90488
commit 18a388c
Show file tree

Hide file tree

Showing 3 changed files with 29 additions and 22 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -13,6 +13,8 @@
 ### 💡 Others
 
 - Refetch devices list after launching a simulator. ([#37](https://github.com/expo/orbit/pull/37) by [@gabrieldonadel](https://github.com/gabrieldonadel))
+- Improve Popover height estimations. ([#38](https://github.com/expo/orbit/pull/38) by [@gabrieldonadel](https://github.com/gabrieldonadel))
+- Add alert when trying to install build with no available device. ([#38](https://github.com/expo/orbit/pull/38) by [@gabrieldonadel](https://github.com/gabrieldonadel))
 
 ## 0.1.1 — 2023-08-10
 

diff --git a/apps/menu-bar/src/popover/Core.tsx b/apps/menu-bar/src/popover/Core.tsx
@@ -1,5 +1,5 @@
 import React, {memo, useCallback, useEffect, useState} from 'react';
-import {SectionList} from 'react-native';
+import {Alert, SectionList} from 'react-native';
 
 import {useDeepLinking} from '../hooks/useDeepLinking';
 import {downloadBuildAsync} from '../commands/downloadBuildAsync';
@@ -29,7 +29,7 @@ import {
 import {useDeviceAudioPreferences} from '../hooks/useDeviceAudioPreferences';
 import {useSafeDisplayDimensions} from '../hooks/useSafeDisplayDimensions';
 import {useExpoTheme} from '../utils/useExpoTheme';
-import SectionHeader from './SectionHeader';
+import SectionHeader, {SECTION_HEADER_HEIGHT} from './SectionHeader';
 import Item from './Item';
 import {FOOTER_HEIGHT} from './Footer';
 
@@ -52,7 +52,7 @@ function Core(props: Props) {
   const [status, setStatus] = useState(Status.LISTENING);
   const [progress, setProgress] = useState(0);
 
-  const {devices} = useListDevices();
+  const {devices, refetch} = useListDevices();
   const {emulatorWithoutAudio} = useDeviceAudioPreferences();
   const theme = useExpoTheme();
 
@@ -64,7 +64,9 @@ function Core(props: Props) {
     FOOTER_HEIGHT -
     BUILDS_SECTION_HEIGHT -
     30;
-  const heightOfAllDevices = DEVICE_ITEM_HEIGHT * devices?.length;
+  const heightOfAllDevices =
+    DEVICE_ITEM_HEIGHT * devices?.length +
+    SECTION_HEADER_HEIGHT * (sections?.length || 0);
   const estimatedListHeight =
     heightOfAllDevices <= estimatedAvailableSizeForDevices ||
     estimatedAvailableSizeForDevices <= 0
@@ -136,7 +138,10 @@ function Core(props: Props) {
         const platform = getPlatformFromURI(url);
         let device = getDeviceByPlatform(platform);
         if (!device) {
-          return; // handle error
+          Alert.alert(
+            `You don't have any ${platform} device available to run this build, please make your environment is configured correctly and try again.`,
+          );
+          return;
         }
 
         const deviceId = getDeviceId(device);
@@ -255,13 +260,9 @@ function Core(props: Props) {
           sections={sections}
           style={{minHeight: estimatedListHeight}}
           SectionSeparatorComponent={Separator}
-          renderSectionHeader={({section: {label}}) => {
-            return (
-              <View px="medium">
-                <SectionHeader label={label} />
-              </View>
-            );
-          }}
+          renderSectionHeader={({section: {label}}) => (
+            <SectionHeader label={label} />
+          )}
           renderItem={({item: device}: {item: Device}) => {
             const platform = getDeviceOS(device);
             const id = getDeviceId(device);

diff --git a/apps/menu-bar/src/popover/SectionHeader.tsx b/apps/menu-bar/src/popover/SectionHeader.tsx
@@ -1,24 +1,28 @@
 import React, {memo} from 'react';
 
-import {Text} from '../components';
+import {Text, View} from '../components';
 import {useTheme} from '../providers/ThemeProvider';
 
+export const SECTION_HEADER_HEIGHT = 20;
+
 type Props = {
   label: string;
 };
 
 const SectionHeader = ({label}: Props) => {
   const theme = useTheme();
   return (
-    <Text
-      weight="semibold"
-      size="tiny"
-      color="default"
-      // @ts-ignore
-      // eslint-disable-next-line react-native/no-inline-styles
-      style={{opacity: theme === 'dark' ? 0.65 : 0.85}}>
-      {label}
-    </Text>
+    <View px="medium">
+      <Text
+        weight="semibold"
+        size="tiny"
+        color="default"
+        // @ts-ignore
+        // eslint-disable-next-line react-native/no-inline-styles
+        style={{opacity: theme === 'dark' ? 0.65 : 0.85}}>
+        {label}
+      </Text>
+    </View>
   );
 };