[menu-bar] Improve feedback to the user when an error occurs

expo · Sep 15, 2023 · df8eabe · df8eabe
1 parent 929fd67
commit df8eabe
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/apps/cli/src/utils.ts b/apps/cli/src/utils.ts
@@ -9,7 +9,11 @@ export function returnLoggerMiddleware(
       console.log(result);
     } catch (error) {
       console.log("---- thrown error ----");
-      console.log(error);
+      if (error instanceof Error) {
+        console.log(error.message);
+      } else {
+        console.log(error);
+      }
     }
   };
 }

diff --git a/apps/menu-bar/src/popover/Core.tsx b/apps/menu-bar/src/popover/Core.tsx
@@ -165,7 +165,9 @@ function Core(props: Props) {
         const deviceId = getDeviceId(device);
         await installAndLaunchAppAsync({ appPath: localFilePath, deviceId });
       } catch (error) {
-        console.log(`error ${error}`);
+        if (error instanceof Error) {
+          Alert.alert('Something went wrong while installing the app.', error.message);
+        }
       } finally {
         setTimeout(() => {
           setStatus(Status.LISTENING);