[cli] Fix mmkv-node not building x64 bindings #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Fix #18 (comment)
The is CLI instacrashing on x64 machines with the following error "mach-o file, but is an incompatible architecture (have 'arm64', need 'x86_64h' or 'x86_64'))". That's because nodejs-mmkv only includes bindings for the current running architecture.
How
Unfortunately nodejs-mmkv does not allow us to build node bindings for multiple architectures (arm64 and x64), which is a requirement for us given that we support both Apple silicon and Inter processors. To fix this I create a fork, mmkv-node-bindings, which allows us to specify the architectures that we want to build through a package.json field. This fork also includes the correct TS typings
Test Plan
archive cli and run it on arm64 and x64