[menu-bar] Bump electron to 33.2.0 and react to 18.3.1 #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrieldonadel
commented
Nov 14, 2024
Comment on lines
+117
to
+133
| export class Logs { | ||
| private logs = this.get(); | ||
|
|
||
| push(log: Log) { | ||
| this.logs.push(log); | ||
| if (Platform.OS === 'web') { | ||
| localStorage.setItem('logs', JSON.stringify(this.logs)); | ||
| } | ||
| } | ||
|
|
||
| get(): Log[] { | ||
| if (Platform.OS === 'web') { | ||
| return JSON.parse(localStorage.getItem('logs') ?? '[]'); | ||
| } | ||
| return this.logs ?? []; | ||
| } | ||
| } |
There was a problem hiding this comment.
In order for the logs to work across multiple windows on react-native web we need to use some sort of storage solution like localStorage
gabrieldonadel
commented
Nov 14, 2024
Comment on lines
+54
to
+57
| mainWindow.webContents.once('dom-ready', () => { | ||
| // Only keep the current session in the logs | ||
| mainWindow.webContents.executeJavaScript("localStorage.setItem('logs', '[]')"); | ||
| }); |
There was a problem hiding this comment.
We need to reset localStorage logs on launch to ignore the logs from the previous session
gabrieldonadel
commented
Nov 14, 2024
| "react-native": "0.76.1", | ||
| "react-native-macos": "0.76.0", | ||
| "react-native-mmkv": "^2.10.2", | ||
| "react-native-svg": "15.8.0", | ||
| "react-native-url-polyfill": "^2.0.0", | ||
| "react-native-vector-icons": "^9.2.0", |
gabrieldonadel
commented
Nov 14, 2024
Comment on lines
+26
to
+29
| "@fluentui/react-progress": "^9.1.90", | ||
| "@fluentui/react-provider": "^9.18.0", | ||
| "@fluentui/react-switch": "^9.1.97", | ||
| "@fluentui/react-theme": "^9.1.22", |
There was a problem hiding this comment.
latest release of @fluentui/react-components is currently broken so we need to use the individual packages directly
gabrieldonadel
changed the title
gabrieldonadel
force-pushed
the
@gabrieldonadel/bump-electron
branch
from
b4d0d5c to
cbfa3c3
Compare
gabrieldonadel
force-pushed
the
@gabrieldonadel/bump-electron
branch
3 times, most recently
from
e5a483a to
5619f72
Compare
gabrieldonadel
force-pushed
the
@gabrieldonadel/bump-electron
branch
from
5619f72 to
539eb94
Compare
alanjhughes
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Orbit dependencies are getting quite outdated
How
Test Plan
Run menubar locally on macOS