[menu-bar] Fix Popover height after putting Mac to sleep #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrieldonadel
changed the title
gabrieldonadel
deleted the
@gabrieldonadel/fix-popover-dimensions-after-unplugging-display
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Closes #22
It seems that there is a bug in
react-native-macoswhen callingDimensions.get('screen')right after unplugging a display and awaking the computer, which results in the Dimensions API returningheight: 0TODO
How
This PR adds a workaround that attempts to mitigate this problem by waiting 100ms and trying to get the screen dimensions again.
Test Plan