Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[menu-bar] Fix local server deeplink #55

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

gabrieldonadel
Copy link
Member

Why

Closes ENG-9945

How

Properly decode and replace URL protocol when using exp:// protocol

Test Plan

Fetch the orbit/open from the website and ensure everything is working as expected

@linear
Copy link

linear bot commented Sep 6, 2023

ENG-9945 Implement local server for deep linking

We should implement a local http server that runs as a subprocess of Orbit to allow us to detect from the website that Orbit is available and running the user machine. We should use a similar approach to the Linear and Slack use.

E.g.

GET http://127.0.0.1:44450/orbit/status

Response 200

{
"name": "orbit",
"version": "1.0.0" 
}

And

POST http://127.0.0.1:44450/orbit/open

body:

{
"url": "xxxxx"  
}

@gabrieldonadel gabrieldonadel merged commit 5fc637c into main Sep 6, 2023
@gabrieldonadel gabrieldonadel deleted the @gabrieldonadel/fix-deeplink-url branch September 6, 2023 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant