[menu-bar] Improve performance when running cli commands #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrieldonadel
added a commit
that referenced
this pull request
Sep 18, 2023
* [menu-bar] Improve performance when running cli commands * Add changelog entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Closes ENG-10052
How
To improve the performance of the
runCommandmethod, this PR introduces the following optimizations:Remove
[task waitUntilExit], which blocks the main thread until the task is completed and usesetReadabilityHandlerandsetTerminationHandlerinstead of relying on NSNotificationCenter for updates to allow asynchronous execution.Move the NSTask execution and reading of output to a background queue
Use NSMutableString to avoid String concatenation on every update
Test Plan
Use Xcode Instruments to profile CPU usage
Before
After