[menu-bar] Patch react-native-svg to support macOS Sonoma #63
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
macOS Sonoma will be officially released on September 26 and with it comes a breaking change to
drawRect
, you can no longer trust that the OS will provide you a dirtyRect that will be within the bounds of your view. Specifically (from the appkit release notes):This causes libraries like
react-native-svg
that rely ondrawRect
to take up the full width/height of your window.Closes ENG-10149
Closes #30
How
Patch react-native-svg
RNSVGSvgView
while software-mansion/react-native-svg#2136 is not mergedTest Plan
Run Orbit on macOS Ventura and Sonoma and ensure SVGs are being rendered properly