[menu-bar] Upgrade react-native to 0.72.5 #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saadnajmi
reviewed
Oct 4, 2023
| @interface AppDelegate : NSObject <NSApplicationDelegate> | ||
| @interface AppDelegate : NSObject <NSApplicationDelegate, NSUserNotificationCenterDelegate> |
There was a problem hiding this comment.
This is actually useful for me to understand how people use the upgrade-helper for macOS, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Closes ENG-10050
How
Upgrade react-native to 0.72.5 based on https://react-native-community.github.io/upgrade-helper/?from=0.71.0&to=0.72.5
Test Plan
Run menu-bar on debug and release mode