[menu-bar][cli] Add support for opening tarballs with multiple apps #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrieldonadel
deleted the
@gabrieldonadel/add-support-for-multi-app-tarballs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Closes ENG-10132
When attempting to open a
.tarfile users would get stuck at the "Installing" stage as the CLI would expect the users to select which app they would like to install using the keyboard, even though the CLI process is not interactive. To fix this and any other problems related to interacting with we should remove theprompslibrary from eas-shared.How
This PR refactors the logic responsible for the communication of errors from the CLI to the menu bar, allowing us to reconstruct the Error object from the cli on the React Native side. Apart from that this PR also adds support for opening tarballs with multiple apps and adds a new native Alert (
showMultiOptionAlert)Test Plan
Screen.Recording.2023-10-10.at.17.43.21.mov