Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes for TV support #77

Merged
merged 1 commit into from
Oct 14, 2023
Merged

Changes for TV support #77

merged 1 commit into from
Oct 14, 2023

Conversation

douglowder
Copy link
Contributor

@douglowder douglowder commented Oct 13, 2023 •
edited
Loading

Why

  • Allow Orbit user to only show certain simulators/emulators (e.g. only iOS or only Android)
  • Allow Orbit user to run Apple TV builds on Apple TV simulators (new experimental feature)

How

  • New user pref "Show experimental features" (false by default)
  • New user prefs to hide/show different simulator types
  • Checkbox in settings UI for the experimental features
  • New row in menu bar UI to switch between different simulator lists
  • Awareness of osType=tvOS in common-types and eas-shared
  • Other changes:
    • Boolean user preferences are now always defined -- defaults in Storage.ts
    • Allow showing debug menu even if we are not logged in

Test Plan

  • Tested on desktop

gabrieldonadel
gabrieldonadel reviewed Oct 13, 2023
View reviewed changes
apps/menu-bar/src/popover/Core.tsx Show resolved Hide resolved
apps/menu-bar/src/utils/device.ts Show resolved Hide resolved
packages/common-types/src/devices.ts Outdated Show resolved Hide resolved
@gabrieldonadel
Copy link
Member

Sorry for the mess, I moved .prettierrc.js to the root folder in another PR but this ended up generating even more conflicts

gabrieldonadel
gabrieldonadel approved these changes Oct 14, 2023
View reviewed changes
Copy link
Member

@gabrieldonadel gabrieldonadel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@douglowder douglowder force-pushed the doug/show-tv-devices branch 4 times, most recently from 09c40f4 to 3e713e8 Compare October 14, 2023 01:37
@douglowder
Changes for TV support
cf48bf0 
- New user pref "Show experimental features" (false by default)
- New user prefs to hide/show different simulator types
- Checkbox in settings for the experimental features
- UI in menu bar dropdown to switch between different simulator lists
- Awareness of osType=tvOS in common-types and eas-shared
- Move .prettierrc.js to top of monorepo
- Boolean user preferences are now always defined -- defaults in Storage.ts
@douglowder douglowder merged commit 6056712 into main Oct 14, 2023
1 check passed
@gabrieldonadel gabrieldonadel deleted the doug/show-tv-devices branch October 14, 2023 05:36
@gabrieldonadel gabrieldonadel mentioned this pull request Oct 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabrieldonadel gabrieldonadel gabrieldonadel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@douglowder @gabrieldonadel