Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Onboarding to rerun checks when focusing the window #93

Merged
merged 4 commits into from
Oct 27, 2023

Conversation

gabrieldonadel
Copy link
Member

Why

Closes ENG-10481

How

  • Add window focus detection
  • Update check-tools command to run checks in parallel
  • Update Onboarding to rerun checks when focusing the window

Test Plan

Screen.Recording.2023-10-27.at.19.40.47.mov

@linear
Copy link

linear bot commented Oct 27, 2023

ENG-10481 Refocusing on the Onboarding window should rerun platform tools check

If the platform tools check fails for any reason, the user focus on a different window and then focus back on the Onboarding window we should rerun the check

@gabrieldonadel gabrieldonadel merged commit cdb39e6 into main Oct 27, 2023
1 check passed
@gabrieldonadel gabrieldonadel deleted the @gabrieldoandel/window-focus branch October 27, 2023 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant