Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[menu-bar] Fix Projects section layout when more than 3 apps are pinned #95

Merged
merged 3 commits into from
Oct 30, 2023

Conversation

gabrieldonadel
Copy link
Member

Why

Closes ENG-10490
Closes ENG-10489

How

Update ProjectsSection component to use a FlatList instead of a .map and update the see all projects link

Test Plan

Pin multiple projects and test the layout

Screen.Recording.2023-10-29.at.23.19.12.mov

@linear
Copy link

linear bot commented Oct 30, 2023

ENG-10490 Update “see all” button link

The projects -> “see all” button links to https://expo.dev/accounts/[account]/projects/[project], but i think it should link to https://expo.dev/accounts/[account]/projects/ (we should only prompt the user to select their account, not a specific project if they want to see all of their projects)

ENG-10489 Fix pinned projects UI when more then 3 projects are pinned

image.png

@gabrieldonadel gabrieldonadel merged commit 304c091 into main Oct 30, 2023
1 check passed
@gabrieldonadel gabrieldonadel deleted the @gabrieldonadel/fix-projects-section branch October 30, 2023 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant