Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix appearance changed into wrong activity #34

Merged
merged 1 commit into from
Jan 23, 2024
Merged

Fix appearance changed into wrong activity #34

merged 1 commit into from
Jan 23, 2024

Conversation

Kudo
Copy link

@Kudo Kudo commented Jan 23, 2024

Why

fixes expo/expo#26556
close ENG-11171

How

the original AppCompatDelegate.setDefaultNightMode() is a global setup. when changing the night mode, it will actually call HomeActivity's onConfigurationChanged. this pr tries to set night mode to current activity by using the setLocalNightMode()

Test Plan

unversioned expo-go with repro from expo/expo#26556

@linear Linear
Copy link

linear bot commented Jan 23, 2024

ENG-11171 Appearance setColorScheme does not work on Android

@Kudo Kudo merged commit cf55a59 into exp-latest Jan 23, 2024
2 checks passed
@Kudo Kudo deleted the @kudo/eng-11171-appearance-setcolorscheme-does-not-work-on-android branch January 23, 2024 10:20
Kudo added a commit that referenced this pull request Jan 23, 2024
@Kudo
Fix appearance changed into wrong activity (#34)
2d00e21 
the original `AppCompatDelegate.setDefaultNightMode()` is a global setup. when changing the night mode, it will actually call HomeActivity's `onConfigurationChanged`. this pr tries to set night mode to current activity by using the `setLocalNightMode()`

(cherry picked from commit cf55a59)
@Kudo Kudo mentioned this pull request Jan 23, 2024
Merged
2 tasks
Kudo added a commit to expo/expo that referenced this pull request Jan 23, 2024
@Kudo
[go] reversion sdk-49 aar (#26624)
bcb991d 
# Why

fixes #26556
fixes #26561
close ENG-11171
close ENG-11173

# How

- the #26556 appearance issue was resolved by
expo/react-native#34. i've cherry-picked the fix
to both sdk-49 and sdk-50 branch of react-native-lab fork.
- the #26561 was coming from incompatible fresco versions. since fresco
was bumped from react-native 0.73, we should re-version sdk-49 aar with
new fresco. here's what i did

# Test Plan

tested on the local versioned release build expo-go
- #26556 for both sdk-49 and sdk-50
- #26561 doesn't have a repro but i can copy a repro from
https://github.com/jobtoday/react-native-image-viewing/tree/master/example
gabrieldonadel pushed a commit that referenced this pull request Jan 29, 2024
@Kudo @gabrieldonadel
Fix appearance changed into wrong activity (#34)
f732599 
the original `AppCompatDelegate.setDefaultNightMode()` is a global setup. when changing the night mode, it will actually call HomeActivity's `onConfigurationChanged`. this pr tries to set night mode to current activity by using the `setLocalNightMode()`
gabrieldonadel pushed a commit that referenced this pull request Feb 6, 2024
@Kudo @gabrieldonadel
Fix appearance changed into wrong activity (#34)
0164c29 
the original `AppCompatDelegate.setDefaultNightMode()` is a global setup. when changing the night mode, it will actually call HomeActivity's `onConfigurationChanged`. this pr tries to set night mode to current activity by using the `setLocalNightMode()`
gabrieldonadel pushed a commit that referenced this pull request Mar 7, 2024
@Kudo @gabrieldonadel
Fix appearance changed into wrong activity (#34)
fb8c9b6 
the original `AppCompatDelegate.setDefaultNightMode()` is a global setup. when changing the night mode, it will actually call HomeActivity's `onConfigurationChanged`. this pr tries to set night mode to current activity by using the `setLocalNightMode()`
gabrieldonadel pushed a commit that referenced this pull request Mar 13, 2024
@Kudo @gabrieldonadel
Fix appearance changed into wrong activity (#34)
20be546 
the original `AppCompatDelegate.setDefaultNightMode()` is a global setup. when changing the night mode, it will actually call HomeActivity's `onConfigurationChanged`. this pr tries to set night mode to current activity by using the `setLocalNightMode()`
alanjhughes pushed a commit that referenced this pull request Mar 21, 2024
@Kudo @alanjhughes
Fix appearance changed into wrong activity (#34)
d8402f3 
the original `AppCompatDelegate.setDefaultNightMode()` is a global setup. when changing the night mode, it will actually call HomeActivity's `onConfigurationChanged`. this pr tries to set night mode to current activity by using the `setLocalNightMode()`
alanjhughes pushed a commit that referenced this pull request Mar 27, 2024
@Kudo @alanjhughes
Fix appearance changed into wrong activity (#34)
2b7056e 
the original `AppCompatDelegate.setDefaultNightMode()` is a global setup. when changing the night mode, it will actually call HomeActivity's `onConfigurationChanged`. this pr tries to set night mode to current activity by using the `setLocalNightMode()`
alanjhughes pushed a commit that referenced this pull request Apr 2, 2024
@Kudo @alanjhughes
Fix appearance changed into wrong activity (#34)
8455ebf 
the original `AppCompatDelegate.setDefaultNightMode()` is a global setup. when changing the night mode, it will actually call HomeActivity's `onConfigurationChanged`. this pr tries to set night mode to current activity by using the `setLocalNightMode()`
alanjhughes pushed a commit that referenced this pull request Apr 8, 2024
@Kudo @alanjhughes
Fix appearance changed into wrong activity (#34)
510dd1f 
the original `AppCompatDelegate.setDefaultNightMode()` is a global setup. when changing the night mode, it will actually call HomeActivity's `onConfigurationChanged`. this pr tries to set night mode to current activity by using the `setLocalNightMode()`
alanjhughes pushed a commit that referenced this pull request Apr 11, 2024
@Kudo @alanjhughes
Fix appearance changed into wrong activity (#34)
efab0ba 
the original `AppCompatDelegate.setDefaultNightMode()` is a global setup. when changing the night mode, it will actually call HomeActivity's `onConfigurationChanged`. this pr tries to set night mode to current activity by using the `setLocalNightMode()`
alanjhughes pushed a commit that referenced this pull request Apr 15, 2024
@Kudo @alanjhughes
Fix appearance changed into wrong activity (#34)
1a6bdb2 
the original `AppCompatDelegate.setDefaultNightMode()` is a global setup. when changing the night mode, it will actually call HomeActivity's `onConfigurationChanged`. this pr tries to set night mode to current activity by using the `setLocalNightMode()`
alanjhughes pushed a commit that referenced this pull request Apr 22, 2024
@Kudo @alanjhughes
Fix appearance changed into wrong activity (#34)
fcb1053 
the original `AppCompatDelegate.setDefaultNightMode()` is a global setup. when changing the night mode, it will actually call HomeActivity's `onConfigurationChanged`. this pr tries to set night mode to current activity by using the `setLocalNightMode()`
alanjhughes pushed a commit that referenced this pull request May 1, 2024
@Kudo @alanjhughes
Fix appearance changed into wrong activity (#34)
8d1d18f 
the original `AppCompatDelegate.setDefaultNightMode()` is a global setup. when changing the night mode, it will actually call HomeActivity's `onConfigurationChanged`. this pr tries to set night mode to current activity by using the `setLocalNightMode()`
alanjhughes pushed a commit that referenced this pull request May 2, 2024
@Kudo @alanjhughes
Fix appearance changed into wrong activity (#34)
2616a49 
the original `AppCompatDelegate.setDefaultNightMode()` is a global setup. when changing the night mode, it will actually call HomeActivity's `onConfigurationChanged`. this pr tries to set night mode to current activity by using the `setLocalNightMode()`
alanjhughes pushed a commit that referenced this pull request Jun 4, 2024
@Kudo @alanjhughes
Fix appearance changed into wrong activity (#34)
4a07aac 
the original `AppCompatDelegate.setDefaultNightMode()` is a global setup. when changing the night mode, it will actually call HomeActivity's `onConfigurationChanged`. this pr tries to set night mode to current activity by using the `setLocalNightMode()`
gabrieldonadel pushed a commit that referenced this pull request Jul 2, 2024
@Kudo @gabrieldonadel
Fix appearance changed into wrong activity (#34)
60dcb81 
the original `AppCompatDelegate.setDefaultNightMode()` is a global setup. when changing the night mode, it will actually call HomeActivity's `onConfigurationChanged`. this pr tries to set night mode to current activity by using the `setLocalNightMode()`
gabrieldonadel pushed a commit that referenced this pull request Jul 17, 2024
@Kudo @gabrieldonadel
Fix appearance changed into wrong activity (#34)
050554a 
the original `AppCompatDelegate.setDefaultNightMode()` is a global setup. when changing the night mode, it will actually call HomeActivity's `onConfigurationChanged`. this pr tries to set night mode to current activity by using the `setLocalNightMode()`
gabrieldonadel pushed a commit that referenced this pull request Jul 17, 2024
@Kudo @gabrieldonadel
Fix appearance changed into wrong activity (#34)
b3529da 
the original `AppCompatDelegate.setDefaultNightMode()` is a global setup. when changing the night mode, it will actually call HomeActivity's `onConfigurationChanged`. this pr tries to set night mode to current activity by using the `setLocalNightMode()`
gabrieldonadel pushed a commit that referenced this pull request Aug 5, 2024
@Kudo @gabrieldonadel
Fix appearance changed into wrong activity (#34)
3197119 
the original `AppCompatDelegate.setDefaultNightMode()` is a global setup. when changing the night mode, it will actually call HomeActivity's `onConfigurationChanged`. this pr tries to set night mode to current activity by using the `setLocalNightMode()`
gabrieldonadel pushed a commit that referenced this pull request Aug 16, 2024
@Kudo @gabrieldonadel
Fix appearance changed into wrong activity (#34)
9f14d62 
the original `AppCompatDelegate.setDefaultNightMode()` is a global setup. when changing the night mode, it will actually call HomeActivity's `onConfigurationChanged`. this pr tries to set night mode to current activity by using the `setLocalNightMode()`
gabrieldonadel pushed a commit that referenced this pull request Aug 22, 2024
@Kudo @gabrieldonadel
Fix appearance changed into wrong activity (#34)
046e035 
the original `AppCompatDelegate.setDefaultNightMode()` is a global setup. when changing the night mode, it will actually call HomeActivity's `onConfigurationChanged`. this pr tries to set night mode to current activity by using the `setLocalNightMode()`
gabrieldonadel pushed a commit that referenced this pull request Oct 8, 2024
@Kudo @gabrieldonadel
Fix appearance changed into wrong activity (#34)
684066e 
the original `AppCompatDelegate.setDefaultNightMode()` is a global setup. when changing the night mode, it will actually call HomeActivity's `onConfigurationChanged`. this pr tries to set night mode to current activity by using the `setLocalNightMode()`
gabrieldonadel pushed a commit that referenced this pull request Oct 10, 2024
@Kudo @gabrieldonadel
Fix appearance changed into wrong activity (#34)
7d47f5c 
the original `AppCompatDelegate.setDefaultNightMode()` is a global setup. when changing the night mode, it will actually call HomeActivity's `onConfigurationChanged`. this pr tries to set night mode to current activity by using the `setLocalNightMode()`
gabrieldonadel pushed a commit that referenced this pull request Oct 16, 2024
@Kudo @gabrieldonadel
Fix appearance changed into wrong activity (#34)
7b05456 
the original `AppCompatDelegate.setDefaultNightMode()` is a global setup. when changing the night mode, it will actually call HomeActivity's `onConfigurationChanged`. this pr tries to set night mode to current activity by using the `setLocalNightMode()`
gabrieldonadel pushed a commit that referenced this pull request Oct 17, 2024
@Kudo @gabrieldonadel
Fix appearance changed into wrong activity (#34)
23fe2df 
the original `AppCompatDelegate.setDefaultNightMode()` is a global setup. when changing the night mode, it will actually call HomeActivity's `onConfigurationChanged`. this pr tries to set night mode to current activity by using the `setLocalNightMode()`
gabrieldonadel pushed a commit that referenced this pull request Oct 23, 2024
@Kudo @gabrieldonadel
Fix appearance changed into wrong activity (#34)
b50a12f 
the original `AppCompatDelegate.setDefaultNightMode()` is a global setup. when changing the night mode, it will actually call HomeActivity's `onConfigurationChanged`. this pr tries to set night mode to current activity by using the `setLocalNightMode()`
gabrieldonadel pushed a commit that referenced this pull request Oct 29, 2024
@Kudo @gabrieldonadel
Fix appearance changed into wrong activity (#34)
048d6bc 
the original `AppCompatDelegate.setDefaultNightMode()` is a global setup. when changing the night mode, it will actually call HomeActivity's `onConfigurationChanged`. this pr tries to set night mode to current activity by using the `setLocalNightMode()`
gabrieldonadel pushed a commit that referenced this pull request Nov 14, 2024
@Kudo @gabrieldonadel
Fix appearance changed into wrong activity (#34)
233006e 
the original `AppCompatDelegate.setDefaultNightMode()` is a global setup. when changing the night mode, it will actually call HomeActivity's `onConfigurationChanged`. this pr tries to set night mode to current activity by using the `setLocalNightMode()`
gabrieldonadel pushed a commit that referenced this pull request Nov 22, 2024
@Kudo @gabrieldonadel
Fix appearance changed into wrong activity (#34)
5de5260 
the original `AppCompatDelegate.setDefaultNightMode()` is a global setup. when changing the night mode, it will actually call HomeActivity's `onConfigurationChanged`. this pr tries to set night mode to current activity by using the `setLocalNightMode()`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanjhughes alanjhughes alanjhughes approved these changes

@lukmccall lukmccall Awaiting requested review from lukmccall

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Appearance setColorScheme does not work on Android
2 participants
@Kudo @alanjhughes