Thread-safe implementation of the sentinel connection pool #4
Conversation
flask_redis_sentinel.py
Outdated
| yield self.get_master_address() | ||
| except MasterNotFoundError: | ||
| pass | ||
| raise SlaveNotFoundError('No slave found for %r' % (self.service_name)) |
There was a problem hiding this comment.
I cant find MasterNotFoundError and SlaveNotFoundError definied anywhere
flask_redis_sentinel.py
Outdated
| return master_address | ||
|
|
||
| def rotate_slaves(self): | ||
| "Round-robin slave balancer" |
There was a problem hiding this comment.
triple quotes should be used for doc string (on multiple methods)
There was a problem hiding this comment.
I was copying the surrounding and didn't notice this. 🤦♂️
flask_redis_sentinel.py
Outdated
| return super(SentinelManagedConnection, self).read_response() | ||
| except ReadOnlyError: | ||
| if self.connection_pool.is_master: | ||
| # When talking to a master, a ReadOnlyError when likely |
There was a problem hiding this comment.
I think 'when' after ReadOnlyError should be removed
flask_redis_sentinel.py
Outdated
| self.get_master_address() | ||
| return False | ||
| if self.is_master: | ||
| if self.master_address != (connection.host, connection.port): |
There was a problem hiding this comment.
I am not sure here but, is it intentional to use self.master_address instead of self.get_master_address()? Maybe self.master_address should also be a private?
There was a problem hiding this comment.
Yes, that's intentional. self.get_master_address() connects to redis sentinel and resolves the current master, self.master_address is a cache from the last call. The resolution is not something that should happen every single time you take/return a connection from the pool.
|
This now depends on https://github.com/exponea/redis-py/releases/tag/2.10.6-exponea-1 |
Thread-safe implementation of the sentinel connection pool, so only one pool per process is now used.
Upstream pull request:
redis/redis-py#909