Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typing IncrementResponse -> ClientRateLimitInfo #192

Closed
wants to merge 1 commit into from

Conversation

shenie
Copy link

@shenie shenie commented Sep 11, 2023

So that this package works with current latest of express-rate-limit which is 6.11.1.


Otherwise we are getting the following error while running latest of express-rate-limit & rate-limit-redis

node_modules/rate-limit-redis/dist/index.d.ts:3:10 - error TS2614: Module '"express-rate-limit"' has no exported member 'IncrementResponse'. Did you mean to use 'import IncrementResponse from "express-rate-limit"' instead?

3 import { IncrementResponse, Options as RateLimitConfiguration, Store } from 'express-rate-limit';
           ~~~~~~~~~~~~~~~~~


Found 1 error in node_modules/rate-limit-redis/dist/index.d.ts:3

So that this package works with current latest of express-rate-limit
which is 6.11.1.
@nfriedly
Copy link
Member

Oh, shoot, we should fix this in express-rate-limit. We can just export the type with both names, making one an alias of the other.

nfriedly added a commit to express-rate-limit/express-rate-limit that referenced this pull request Sep 12, 2023
nfriedly added a commit to express-rate-limit/express-rate-limit that referenced this pull request Sep 12, 2023
nfriedly added a commit to express-rate-limit/express-rate-limit that referenced this pull request Sep 12, 2023
nfriedly added a commit to express-rate-limit/express-rate-limit that referenced this pull request Sep 12, 2023
fixes express-rate-limit/rate-limit-redis#192

also remove unnecessary ratelimit redis types from integration test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants