Add logout method #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baurmatt
force-pushed
the
add/logout-method
branch
from
9dabbb9
to
eb91c1d
Compare
baurmatt
force-pushed
the
add/logout-method
branch
from
eb91c1d
to
40ea15e
Compare
|
We've been running into issues because there were 10's of thousands of sessions in the table, and this patch has solved that for us. So we're eager to see this get merged. |
|
LGTM |
|
Thanks @baurmatt ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements support for the logout method. This should be always used to destroy the users session as it would otherwise pile up in the servers sessions table.
I would have also written a test but I'm not quite sure how it could look like :(