Use headersSent instead of _header

[maritz]

As discussed in #127 this PR now includes the changes that do break node v0.8 and has tests.

I did not remove the travis config for v0.8 since I'm not sure that's something that should be in a PR.

[maritz]

Hm, I just noticed that I branched from my other changes. Should I remove those changes from this PR?

[dougwilson]

Hi @maritz I can try to cut them out myself during the merge, but if you can remove them, that may be good especially in case something else changes (either in the other PR or between that PR merging and the major release to include this change).

[maritz]

@dougwilson I rebased and cut out the extra commits.

[lamweili]

Would this change be better?
It will be backwards compatible with Node.js v0.8 and not incur a semver major.

[lamweili]

For background information regarding res._header and res.headersSent equivalence:
https://github.com/nodejs/node/blob/93e0bf9abf350637d772bcce14a5d9527b733300/lib/_http_outgoing.js#L741-L746

We can also add test cases to assert the equivalence (if really required).
The code snippet is available @ expressjs/session@35880d6.

[bjohansebas]

We can also add test cases to assert the equivalence (if really required).
The code snippet is available @ expressjs/session@35880d6.

@lamweili I don't think we need a test for this, this change was also made in pillarjs/finalhandler#15.

[bjohansebas]

LGTM

[lamweili]

We can also add test cases to assert the equivalence (if really required).
The code snippet is available @ expressjs/session@35880d6.

@lamweili I don't think we need a test for this, this change was also made in pillarjs/finalhandler#15.

All good, was coming from test/code coverage perspective.

[lamweili]

LGTM

(can't approve cause I don't have explicit access to this repository)
😮‍💨

[bjohansebas]

thanks @maritz