Added support for brotli ('br') content-encoding

[danielgindi]

expressjs/body-parser#403

https://medium.com/oyotech/how-brotli-compression-gave-us-37-latency-improvement-14d41e50fee4
https://caniuse.com/#feat=brotli

[dougwilson]

Make sure to update the documentation as well around it supporting br.

[danielgindi]

@dougwilson There's an issue with object-assign polyfill - it does not support the very outdated versions of node.js

[dougwilson]

There's an issue with object-assign polyfill - it does not support the very outdated versions of node.js

I guess just pick a different module or an older version of that module.

[dougwilson]

I added a comment about the faster statement and still have an open question on how a user can change compression level of br.

[dougwilson]

I added a comment about the faster statement and still have an open question on how a user can change compression level of br. I'm also having trouble to actually get br compression to even work at all with Chrome. I'm trying to figure it out, as our number 1 issue opened here is how to get this module working, so having concrete information for how to get br working with a web browser (Chrome, for instance) would help a lot. For reference I used the example in the README and your branch and Chrome continues to only show it using gzip, even when the connection is https (which my understanding is a requirement for br to work in Chrome).

[danielgindi]

I added a comment about the faster statement and still have an open question on how a user can change compression level of br. I'm also having trouble to actually get br compression to even work at all with Chrome. I'm trying to figure it out, as our number 1 issue opened here is how to get this module working, so having concrete information for how to get br working with a web browser (Chrome, for instance) would help a lot. For reference I used the example in the README and your branch and Chrome continues to only show it using gzip, even when the connection is https (which my understanding is a requirement for br to work in Chrome).

Look at Chrome's Accept-Encoding: gzip, deflate, br - it puts br last. I'm guessing they put it last as a transition period, as some poor servers out there fail when brotli is specified, or intermediaries doing even worse.

Or maybe it's because when it first arrived they considered it a good compression for WOFF fonts, but they always tested with the highest compression levels. Today people know that with level 4 you have better results on all kinds of files.

[danielgindi]

@dougwilson you have a PR pending

[danielgindi]

I guess everyone are in vacation now

[nicksrandall]

@danielgindi just want to say that this is good work. Thanks for pushing for this.

[danielgindi]

At this point I'm convinced this is not going to happen.

[Kle0s]

At this point I'm convinced this is not going to happen.

Would you like to create an npm package from your fork? Or should I? I really think it's much needed (and would like to use it myself)

[nicksrandall]

If it is helpful, I’ve built this package and am using it in production in several places: https://github.com/nicksrandall/compression

[maggie44]

If it is helpful, I’ve built this package and am using it in production in several places: https://github.com/nicksrandall/compression

Tempting, thanks for this. How has it been running, any issues?

And this one that seems pretty active: https://github.com/Econify/compression-next#readme

[vinayakkulkarni]

LGTM

[nithin-murali-arch]

Looks like the PR is approved, could you folks resolve the conflicts and merge? Is there anything else we're waiting on?

[dgautsch]

Any plans on having this merged or is https://www.npmjs.com/package/shrink-ray-current the current best solution?

[barnhill]

Is there any current movement on getting this approved and merged? Im asking in reference to Apollo Server which we use for GraphQL. It doesn't support Brotli due to this dependency not supporting it.

[MannyPamintuanAtHeb]

@dougwilson, I was curious if you have the bandwidth to review this PR and provide a secondary approval with @vinayakkulkarni having already reviewed and approved?

Seeing br support land for Express would be impactful to apollo-server-express which currently at this time does not support br for compression.

Anything that the community can do to help see this PR land and become a reality?

[romgrk]

Realistically this repository should be considered abandoned, the maintainers haven't responded in a long time and brotli has been out for around 8 years so it's safe to assume there is no interest to add it. The community should probably rally around one of the multiple existing forks for this package. Maybe express-compression would be good?

[bjohansebas]

@danielgindi @nicksrandall Thank you for this work, it has been used as a reference to move forward with #194. You can continue helping by reviewing #194 so we can launch it soon.