perf: normalize secret argument only once

closes #46
expressjs · Dec 20, 2018 · 7ea8ab3 · 7ea8ab3
1 parent 49aca50
commit 7ea8ab3
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/HISTORY.md b/HISTORY.md
@@ -1,3 +1,8 @@
+unreleased
+==========
+
+  * perf: normalize `secret` argument only once
+
 1.4.3 / 2016-05-26
 ==================
 

diff --git a/index.js b/index.js
@@ -37,15 +37,16 @@ module.exports.signedCookies = signedCookies
  */
 
 function cookieParser (secret, options) {
+  var secrets = !secret || Array.isArray(secret)
+    ? (secret || [])
+    : [secret]
+
   return function cookieParser (req, res, next) {
     if (req.cookies) {
       return next()
     }
 
     var cookies = req.headers.cookie
-    var secrets = !secret || Array.isArray(secret)
-      ? (secret || [])
-      : [secret]
 
     req.secret = secrets[0]
     req.cookies = Object.create(null)