Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EFI: Express documentation (expressjs.com website) #211

Open
crandmck opened this issue Mar 7, 2024 · 2 comments
Open

EFI: Express documentation (expressjs.com website) #211

crandmck opened this issue Mar 7, 2024 · 2 comments
Labels

Comments

@crandmck
Copy link
Member

crandmck commented Mar 7, 2024

Documentation needs to be considered as a key task and "first-class citizen". I'm copying some information from #198 here and I'll close that issue in favor of this one. NOTE: I added the top-priority label to this so it will be automatically added to the TC meeting agenda, as I'd like to discuss some items with the TC.

Top-level doc work includes:

  • Fixing known errors/problems in the existing (4.x) doc (see Doc PRs and issues)
  • Improving the completeness and accuracy of existing (4.x & 5.x) doc (via new issues/PRs)
  • Removing old/irrelevant info in the existing (4.x) doc

5.x specific work:

  • Documenting new 5.x releases (API doc)
  • Writing tasks and tutorials for 5.x

Other (non-content) work:

  • Improving the usability of the doc site
  • Improving the tooling/framework used for the doc (Jekyll currently)

Doc PRs and issues

I've been working to review and merge as many PRs as possible. I added some labels to help with organization. So far, I've labeled open PRs:

  • Needs tech review for change that I'm not comfortable merging until reviewed by someone with deeper tech knowledge. This could be a TC member, or anyone else who wants to help with docs, e.g. @waleedtariq109.
  • 5.x for changes that are specific to 5.x
  • UI for changes to the site interface itself (not content).
  • localization changes related to translations, i.e. non-English content.
  • enhancement for changes/additions to "ancillary" doc pages, e.g. Template engines, Frameworks and other stuff that's not specifically technical docs for Express, related middleware, etc. These are lower priority since they are not the core mission of the docs, and IMO we could even move this info into the GH wiki to reduce the number of incoming PRs/issues.

What's the best way for me to get tech reviews for doc changes? I've just been tagging folks like @UlisesGascon but is there a better way?

Next, I'll try to review all the open issues to label and triage them.

Removing old/irrelevant info (DONE)

NOTE: This was done with expressjs/expressjs.com#1484

I wonder if we can just remove these pages:

While these topics are relevant and there are historical reasons for having these pages, IMO they are beyond the scope of the Express documentation. There is so much higher priority work to do and we should focus on documenting Express itself and closely-related stuff in pillarjs and jshttp.

Related discussion: #105

See also the "enhancement" label mentioned above.

I'd also like to discuss removing the BLM banner that TJ added via direct commit several years ago. While it's of course a worthy cause I don't think it's appropriate and it was added outside the normal PR process.

Work for 5.x

We need to think about what doc tasks re to 5.x will give us the most "bang for the buck," e.g. writing tutorials, enhancing the migration guide / summarizing diffs with 4.x, detailed API doc review, etc.

Committers

Finally, we need to review the approved committers to the repo: https://github.com/expressjs/discussions/settings.

Issue triage

We should have a general process to triage incoming issues (and PRs). For example:

  • Any issue that's merely a question (e.g. "How do I do xyz in Express?") should be labeled as question and closed with stock answer that we don't provide tech support.
  • I'll work to document the rules I outlined in the "Doc PRs and issues" section above and we should follow them, assuming we agree.
  • Issues that are about the software (i.e. bug reports, etc.) and not the docs should be moved to the express or other relevant repo (more specifics TBD). It's common to require some investigation to determine if something is actually a issue in the software or an issue with the docs. For that reason, issues will often require technical review and discussion to get to the root issue.
  • Anything else?
@bjohansebas
Copy link
Member

bjohansebas commented Aug 1, 2024

We can draw inspiration from this copy of the Express documentation made with Starlight:

Repo: https://github.com/bjohansebas/expressjs.com
URL: https://dub.sh/expressjs

@bjohansebas
Copy link
Member

Static site generators like VitePress, Docusaurus, or Starlight use MDX. We could gradually replace Liquid (used by Jekyll) with MDX in various PRs, which would then facilitate a migration to a more modern framework later on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants