-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove ancillary pages and corresponding menu nav items #1484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crandmck
requested review from
a team and
wesleytodd
and removed request for
a team and
wesleytodd
April 11, 2024 04:14
wesleytodd
approved these changes
Apr 11, 2024
jonchurch
requested changes
Apr 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Read through the english removals. We are nuking some whole pages, but also removing references to those pages from other content, which is why the diff is as large as it is.
I left a suggestion for wording, LGTM either way though
jonchurch
approved these changes
Apr 13, 2024
UlisesGascon
approved these changes
Apr 15, 2024
This was referenced Apr 17, 2024
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per discussion in TC and:
Details are laid out in https://github.com/expressjs/expressjs.com/wiki/Discuss:-Remove-pages-from-docs.
Not previously discussed: The home page has a "Frameworks" tile with a link to one of the pages being removed.