Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Express-introduction: Broken link #34481

Closed
Sokolan opened this issue Jun 28, 2024 · 4 comments · Fixed by #34527
Closed

Express-introduction: Broken link #34481

Sokolan opened this issue Jun 28, 2024 · 4 comments · Fixed by #34527
Labels
broken link external The external doc we want to link to exists, but the link href is incorrect. Content:Learn:Express Learning area Express docs

Comments

@Sokolan
Copy link

Sokolan commented Jun 28, 2024

MDN URL

https://developer.mozilla.org/en-US/docs/Learn/Server-side/Express_Nodejs/Introduction

What specific section or headline is this issue about?

https://developer.mozilla.org/en-US/docs/Learn/Server-side/Express_Nodejs/Introduction#rendering_data_views

What information was incorrect, unhelpful, or incomplete?

The provided link to the list of template engines is broken.

What did you expect to see?

working link.

Do you have any supporting links, references, or citations?

After taking a look at the express github repo it seems like they've removed the page.
The same PR also removed another broken link which was mentioned here.

Do you have anything more you want to share?

No response

MDN metadata

Page report details
@Sokolan Sokolan added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Jun 28, 2024
@github-actions github-actions bot added the Content:Learn:Express Learning area Express docs label Jun 28, 2024
@bsmth
Copy link
Member

bsmth commented Jun 28, 2024

Thanks for reporting. We could replace with https://expressjs.com/en/guide/using-template-engines.html, what do you think?

@bsmth bsmth added broken link external The external doc we want to link to exists, but the link href is incorrect. and removed needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. labels Jun 28, 2024
@Sokolan
Copy link
Author

Sokolan commented Jun 28, 2024

That link is already provided in the end of the template section:
For more information see Using template engines with Express (Express docs).
I think it would be a duplication, and there's a minimal information regarding what template engines work with express (from the provided link):

Some popular template engines that work with Express are Pug, Mustache, and EJS. The Express application generator uses Jade as its default, but it also supports several others.

I'm currently studying the subject (that's why I've stumbled the broken link) so maybe I'm maybe I'm wrong about it.

@hamishwillee
Copy link
Collaborator

Thanks. That is so annoying - we only fixed up the original link in March #32461.

I'll fix this with some words about the supported versions. Note, not quite those words though, since we don't want to recommend Jade, which become Pug.

@hamishwillee
Copy link
Collaborator

Done in #34527

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
broken link external The external doc we want to link to exists, but the link href is incorrect. Content:Learn:Express Learning area Express docs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants