Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

asset optimizations #1489

Closed
wants to merge 3 commits into from
Closed

asset optimizations #1489

wants to merge 3 commits into from

Conversation

MehfoozurRehman
Copy link
Contributor

so assets consume less bandwidth.

ImgBotApp and others added 2 commits April 14, 2024 20:11
@ImgBotApp
[ImgBot] Optimize images
827c71b 
*Total -- 373.53kb -> 335.41kb (10.21%)

/images/express-facebook-share.png -- 26.42kb -> 10.96kb (58.51%)
/images/companies/kuali-logo.png -- 11.30kb -> 5.55kb (50.92%)
/images/companies/exove-logo.png -- 12.30kb -> 7.39kb (39.87%)
/images/companies/ilovecoding-logo.png -- 27.23kb -> 20.31kb (25.42%)
/images/companies/workinbiotech-logo.png -- 2.44kb -> 1.85kb (24.15%)
/images/expressjs-strongloop-training.svg -- 12.41kb -> 11.85kb (4.54%)
/images/companies/uber-logo.png -- 1.15kb -> 1.10kb (3.83%)
/fonts/fontawesome-webfont.svg -- 280.28kb -> 276.39kb (1.39%)

Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com>
@MehfoozurRehman
Merge pull request #1 from MehfoozurRehman/imgbot
e7b9baf 
[ImgBot] Optimize images
@crandmck
Copy link
Member

Many of these assets are no longer used due to landing #1484. But some (e.g. the Express logo) are still used.

Using less bandwidth is good, so I'm inclined to land it, but can anyone speak to the specific details of the changes in this PR?

NOTE: We also need a PR to remove all the company logos that used to be on the "Companies using Express" page removed in the above-mentioned PR. Any takers?

@chrisdel101
Copy link
Contributor

chrisdel101 commented Apr 21, 2024 •
edited
Loading

What do you need removed? I can do it. Do I need to wait until this PR #1489 is merged before doing it?

@crandmck
Copy link
Member

Some of the files modified in this PR are no longer used. For example, I believe that the files in images/companies are no longer used anywhere since #1484 landed.

So modifying them doesn't serve any purpose. How about removing them in this PR, then we can land it?
Ideally, we would have some way of determining ALL the images that are no longer used, and just remove them, but that might be asking too much :-)

@MehfoozurRehman
Copy link
Contributor Author

ok i am on it.

@chrisdel101
Copy link
Contributor

chrisdel101 commented Apr 21, 2024 •
edited
Loading

Sorry, thought you were asking for a diff PR for a separate issue. If this is the case I can do that. But don't want to interfere with this current PR.

@MehfoozurRehman MehfoozurRehman closed this by deleting the head repository Apr 21, 2024
@MehfoozurRehman MehfoozurRehman mentioned this pull request Apr 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MehfoozurRehman @crandmck @chrisdel101 @ImgBotApp