Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change badges to use badgen.net #66

Closed
styfle opened this issue Aug 9, 2018 · 11 comments
Closed

Change badges to use badgen.net #66

styfle opened this issue Aug 9, 2018 · 11 comments

Comments

@styfle
Copy link

styfle commented Aug 9, 2018

@amio Created a new badge service called https://badgen.net that appears to load badge much faster than the overloaded https://shields.io service.

Would you be interested in switching badges to use this newer, faster service?

@dougwilson
Copy link
Contributor

It does looks much faster and at a glace it looks like it supports all the badges we're using. Didn't look yet if it supports custom names (like "Linux" or "Windows" for the builds). I couldn't find their tracking policy anywhere looking around quickly if you happen to know. Since images automatically load when users open the README files in various things like their editors, we want to be courteous to our users 👍

@dougwilson
Copy link
Contributor

Didn't look yet if it supports custom names (like "Linux" or "Windows" for the builds).

It does support this.

@dougwilson
Copy link
Contributor

From https://github.com/amio/badgen-service :

Shields […] leaves more and more broken badges in READMEs.

I have been seeing that a lot recently, so this would be a welcome change.

Still trying to find any kind of policy for their service irt tracking / whatnot. I may need to contact the owner(s) if I cannot find anything online.

@styfle
Copy link
Author

styfle commented Aug 9, 2018

Since images automatically load when users open the README files in various things like their editors, we want to be courteous to our users

Good point! I'm not sure about the tracking policies.
What kind of tracking is (or is not) acceptable?

I tagged @amio so we should hear something shortly.

@amio
Copy link

amio commented Aug 10, 2018

Hi everyone! As the tracking concern, currently Badgen's tracking & logs:

  • Google Analytics on doc page (home, /docs/packagephobia, etc.)
  • Live badge request time on server side, like:
    2018-08-10T02:26:56.940Z  #npm dm/nuxt: 45.646ms
    2018-08-10T02:26:56.960Z  #npm license/nuxt: 290.487ms
    2018-08-10T02:26:57.113Z  #circleci github/nuxt/nuxt.js: 603.977ms
    2018-08-10T02:27:08.619Z  #npm v/npm: 712.037ms
    2018-08-10T02:27:10.198Z  #npm dt/camaro: 33.761ms
    2018-08-10T02:27:10.371Z  #appveyor ci/tuananh/camaro/master: 651.733ms
    2018-08-10T02:27:10.391Z  #npm v/camaro: 488.829ms
    2018-08-10T02:27:10.411Z  #travis tuananh/camaro/master: 508.989ms
    

I think that could be considered as "no tracking" for badges. Tell me what you think 🤗

@dougwilson
Copy link
Contributor

Thanks @amio ! I vote to move to switch all our badges from shields.io to badgen.net . I will test it on badgeboard first (https://expressjs.github.io/badgeboard/ for the uninitiated). It is pretty slow and sometimes has trouble loading everything for a while now. Should be much better after switching

@LinusU
Copy link
Member

LinusU commented Aug 10, 2018

Live badge request time on server side, like:

As long as it doesn't include the IP address I don't see a problem with it 👍

@dougwilson
Copy link
Contributor

I found the following bug which would be a blocker to switch our badges from shields.io to badgen.net until it is sorted out:

badgen/badgen.net#96

The summary is that coveralls badges on shields.io show the repo code while badgen.net is showing the most recent pr instead, which means our coverage badge would not be meaningful in at way on badgen.net service :(

@amio
Copy link

amio commented Aug 10, 2018

It's fixed now :D


https://flat.badgen.net/coveralls/c/github/expressjs/morgan/master

@styfle
Copy link
Author

styfle commented Aug 16, 2018

Should we add "install size" to the badge board now?

@styfle
Copy link
Author

styfle commented Oct 11, 2018

Closing since this is complete and install size is available since repo-utils/badgeboard#34

See https://expressjs.github.io/badgeboard/

@styfle styfle closed this as completed Oct 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants