Coveralls branch percentage bug?

[dougwilson]

I'm not sure if this is a bug in badgen or Coveralls API, but shields.io seems to be returning the expected 100% while badgen seems to be using a percentage from a recent PR.

Badgen URL: https://flat.badgen.net/coveralls/c/github/expressjs/morgan/master
shields.io URL: https://img.shields.io/coveralls/expressjs/morgan/master.svg?style=flat-square

Rendered:
Badgen:
shields.io:

[amio]

Hmm 🤔

For master branch, this api
https://coveralls.io/github/expressjs/morgan.json?branch=master returns 99.13 (right now),

And the "default" endopoint:
https://coveralls.io/github/expressjs/morgan.json returns 99.15 (right now)

[dougwilson]

I mostly expected it was going tot be a bug in the Coveralls API. Not sure how shields.io is getting 100% (it's possible they have it cached maybe -- though the build the lower % is from is quite old so 🤷‍♂️ ).

Thanks for taking a look @amio

[dougwilson]

It looks like shields.io is not even using an API for coveralls is what's happening -- it just loads https://coveralls.io/repos/github/expressjs/morgan/badge.svg?branch=master under the hood, looks at the Location response header and parses the percentage from that. I wonder why they go through that trouble 🤔 Maybe the Coveralls API has just always been broken?

[dougwilson]

Source ref: https://github.com/badges/shields/blob/master/server.js#L2168-L2214

[amio]

I think what they do is getting the result of coveralls.io's default badge data.

coveralls.io use redirection for performance (no need to generate badge svg on the fly), then shields.io read the Location header for faster result.

[amio]

coveralls.io's "official" badge shows coverage | 100% while their page reporting COVERAGE DECREASED (-0.4%) TO 99.138% 😅

Seems the official badge might be outdated sometime, and shields.io try to be consistent with official badge.

[dougwilson]

Well, 100% is correct for master branch. The lower % you are seeing is from a pull request.

Using shields.io means that a badge will show coverage of repo code but switching to badgen.net with this bug means it will show whatever the most recent pr to the repo is instead it seems.

[amio]

Hmm, yes. If there's no api for that, I should use same method as shields.

[dougwilson]

This is amazing, thank you!

[tunnckoCore]

Call it Coveralls, and don't hate it more. 🤣

[amio]

What? Call it "coveralls" on label?

[tunnckoCore]

No no.. :D Just trolling Coveralls, cuz always was not good.

[amio]

😂