Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis config updated to contain latest supported versions of Node.js #21

Closed
wants to merge 1 commit into from

Conversation

ppitonak
Copy link
Contributor

No description provided.

@dougwilson
Copy link
Contributor

Thanks! Unfortunately this isn't the way the Travis versions are done in our org. We usually have the current minor listed for all majors above the package.json listed minimum.

Copy link
Contributor

@dougwilson dougwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the list from the feedback.

@ppitonak
Copy link
Contributor Author

Do I understand it correctly that you want 4.6, 5.12, 6.9 and 7.1 listed instead of 4, 5, 6, and 7? What about versions that are no longer supported - 0.8, 0.10, 1.x, 2.x, 3.x and 5.x?

@dougwilson
Copy link
Contributor

Yes, list all current minors for all majors above the package.json listed minimum.

@ppitonak ppitonak closed this Nov 15, 2016
@dougwilson dougwilson self-assigned this Nov 15, 2016
@dougwilson dougwilson added the pr label Nov 15, 2016
dougwilson pushed a commit that referenced this pull request Nov 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants