lint: rename .eslintrc to .eslintrc.yml #3561
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iwko
approved these changes
Feb 13, 2018
|
Nice, didn't even know this! Is it possible to name it |
dougwilson
reviewed
Feb 13, 2018
.eslintrc.yaml
Outdated
| eol-last: error | ||
| indent: [error, 2, {SwitchCase: 1}] | ||
| no-trailing-spaces: error | ||
| no-unused-vars: [error, {vars: all, args: none, ignoreRestSiblings: true }] |
There was a problem hiding this comment.
There is a space before the ending } but the space isn't balanced on the other side.
hiroppy
force-pushed
the
feature/rename-eslintrc
branch
2 times, most recently
from
960bc43
to
8afd9e8
Compare
|
@dougwilson PTAL;) |
dougwilson
approved these changes
Feb 13, 2018
wesleytodd
approved these changes
Feb 13, 2018
hiroppy
changed the title
hiroppy
force-pushed
the
feature/rename-eslintrc
branch
from
8afd9e8
to
1e0ffa0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.eslintrcis deprecated.See https://eslint.org/docs/user-guide/configuring#configuration-file-formats.
I changed to
.eslintrc.yamlbecause Node is using Yaml.(nodejs/node#7699)