Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auth test errors in node >8 #3705

Closed
wants to merge 1 commit into from

Conversation

wesleytodd
Copy link
Member

The tests on the 5.x branch were failing in node>8 because digest is now required. This fixes that missing argument.

@wesleytodd wesleytodd requested a review from dougwilson August 6, 2018 00:08
@wesleytodd
Copy link
Member Author

@dougwilson Is there a reason we still have both a 5.x and a 5.0 branch? This happens every time I pick back up some of these PRs I have, and I can never remember why we have both and which is meant for what. #3218 was against 5.x, as are many others, but the main PR is 5.0. Is this PR pointless because I should have been rebasing to 5.0?

@dougwilson
Copy link
Contributor

The {major}.x branches point to whatever the most recent tagged commit is on that major while branches that are {major}.{minor} are release branches for staging that specific release.

@dougwilson
Copy link
Contributor

@dougwilson
Copy link
Contributor

Looks like the CI failed and this doesn't merged into the 5.x branch without conflicts. I think this underlying issue was already fixed, though.

@wesleytodd
Copy link
Member Author

Yeah I think I will just close this. I will make the new PR for that feature against 4.x and then see if this comes up again as I port it to the 5.0.

@wesleytodd wesleytodd closed this Aug 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants