Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: expression minor bugs #3812

Merged
merged 1 commit into from
Dec 18, 2018
Merged

fix: expression minor bugs #3812

merged 1 commit into from
Dec 18, 2018

Conversation

A1vinSmith
Copy link
Contributor

No description provided.

wesleytodd
wesleytodd previously requested changes Nov 29, 2018
View reviewed changes
Copy link
Member

@wesleytodd wesleytodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes @foyangyu. Other than the small formatting thing I do not see any issues with getting these merged.

test/middleware.basic.js Outdated Show resolved Hide resolved
@dougwilson dougwilson self-assigned this Dec 18, 2018
@dougwilson dougwilson changed the base branch from master to 4.17 December 18, 2018 04:00
@dougwilson dougwilson dismissed wesleytodd’s stale review December 18, 2018 04:01

removed test style change

@dougwilson
Copy link
Contributor

I went ahead and just removed the style change from the test that was the requested change from the review so we can land this one after CI passes.

@dougwilson dougwilson merged commit 02f3933 into expressjs:4.17 Dec 18, 2018
dougwilson pushed a commit that referenced this pull request Apr 17, 2019
@dougwilson
examples: minor fixes to some examples
5370213 
closes #3812
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougwilson dougwilson dougwilson left review comments

@wesleytodd wesleytodd wesleytodd left review comments

Assignees

@dougwilson dougwilson

Labels
examples pr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@A1vinSmith @dougwilson @wesleytodd