Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(travis) add node 12 #3946

Merged
merged 1 commit into from
May 16, 2019
Merged

chore(travis) add node 12 #3946

merged 1 commit into from
May 16, 2019

Conversation

zuohuadong
Copy link
Contributor

No description provided.

dougwilson
dougwilson suggested changes Apr 30, 2019
View reviewed changes
Copy link
Contributor

@dougwilson dougwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the appveyor.yml as well 👍

@dougwilson dougwilson added the pr label Apr 30, 2019
@dougwilson dougwilson self-assigned this May 9, 2019
@dougwilson
Copy link
Contributor

@zuohuadong ?

@zuohuadong
Copy link
Contributor Author

@zuohuadong ?

Sorry, I didn't see it before.

@zuohuadong
Copy link
Contributor Author

@zuohuadong ?
I've already finished.

@zuohuadong
Copy link
Contributor Author

Should we remove some versions that are no longer officially supported by node.js?

@LinusU
Copy link
Member

LinusU commented May 10, 2019

Should we remove some versions that are no longer officially supported by node.js?

We can only remove support for older Node.js runtimes in a breaking change, so that will have to happen on the 5.x branch...

@dougwilson dougwilson mentioned this pull request May 16, 2019
Merged
23 tasks
@dougwilson dougwilson added this to the 4.17 milestone May 16, 2019
@dougwilson dougwilson changed the title chore(travis) add node 10 11 12 chore(travis) add node 12 May 16, 2019
@dougwilson dougwilson changed the base branch from master to 4.17 May 16, 2019 04:59
@dougwilson
Copy link
Contributor

I re-targeted the PR to the 4.17 branch and only 12 was not covered, so just updated the PR to be adding Node.js 12.

@dougwilson dougwilson merged commit b9ecb9a into expressjs:4.17 May 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougwilson dougwilson dougwilson approved these changes

Assignees

@dougwilson dougwilson

Labels
pr
Projects
None yet
Milestone
4.17
Development

Successfully merging this pull request may close these issues.
3 participants
@zuohuadong @dougwilson @LinusU