Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

examples: defend from xss #4119

Merged
merged 1 commit into from
Mar 25, 2020
Merged

examples: defend from xss #4119

merged 1 commit into from
Mar 25, 2020

Conversation

KoyamaSohei
Copy link
Contributor

fix: #3992

@KoyamaSohei KoyamaSohei changed the title examples: defend xss examples: defend from xss Dec 13, 2019
@KoyamaSohei
Copy link
Contributor Author

@dougwilson
I would like to ask for review when you are not busy, thanks!

@dougwilson dougwilson mentioned this pull request Mar 25, 2020
Closed
UlisesGascon
UlisesGascon approved these changes Mar 25, 2020
View reviewed changes
Copy link
Member

@UlisesGascon UlisesGascon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KoyamaSohei thanks for this PR!

LGTM ❤️

@UlisesGascon
Copy link
Member

@dougwilson should be merge it? :-)

@dougwilson
Copy link
Contributor

I just rebased it and changed to escape html lib last night. Plan to get it merged today, yes. CI was still running when I went to sleep.

@dougwilson
Copy link
Contributor

It looks like as of this morning, Travis CI is no longer connected to any of our repositories; I am investigating.

@dougwilson dougwilson self-assigned this Mar 25, 2020
@dougwilson dougwilson merged commit 323a389 into expressjs:master Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UlisesGascon UlisesGascon UlisesGascon approved these changes

@dougwilson dougwilson dougwilson approved these changes

Assignees

@dougwilson dougwilson

Labels
examples pr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

XSS in examples
3 participants
@KoyamaSohei @UlisesGascon @dougwilson