Skip to content

Conversation

@Abhishek01039
Copy link

No description provided.

@Abhishek01039
Copy link
Author

Abhishek01039 commented May 15, 2021

@dougwilson
Copy link
Contributor

The source code for express 4 (what you are making your pr for) is supposed to be es5.

@Abhishek01039
Copy link
Author

Oh ok then which branch I should target?

@dougwilson
Copy link
Contributor

What is the goal of the pr? There is no description to understand the goal you are trying to achieve to best guide you.

@Abhishek01039
Copy link
Author

Try to use const wherever possible

@dougwilson
Copy link
Contributor

Oh, i see. If that is the case, it seems like a duplicate of #3427

@Abhishek01039
Copy link
Author

oh my bad!

@Abhishek01039
Copy link
Author

why that PR is not lands to master yet!

@dougwilson
Copy link
Contributor

Master is express 4, which is es5 syntax.

@Abhishek01039
Copy link
Author

express 5?

@dougwilson
Copy link
Contributor

Please comment about that pr in that pr thread. Looking at it you can see the author was asked to make a change and no change has yet been pushed by the author that was requested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants