-
-
Notifications
You must be signed in to change notification settings - Fork 21.9k
Refactor auth example #4591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor auth example #4591
Conversation
|
CI is unhappy with this error https://travis-ci.org/github/expressjs/express/jobs/771206074#L2426 and solution might be this https://stackoverflow.com/questions/42706584/eslint-error-parsing-error-the-keyword-const-is-reserved |
|
The source code for express 4 (what you are making your pr for) is supposed to be es5. |
|
Oh ok then which branch I should target? |
|
What is the goal of the pr? There is no description to understand the goal you are trying to achieve to best guide you. |
|
Try to use |
|
Oh, i see. If that is the case, it seems like a duplicate of #3427 |
|
oh my bad! |
|
why that PR is not lands to master yet! |
|
Master is express 4, which is es5 syntax. |
|
express 5? |
|
Please comment about that pr in that pr thread. Looking at it you can see the author was asked to make a change and no change has yet been pushed by the author that was requested. |
No description provided.