-
-
Notifications
You must be signed in to change notification settings - Fork 17.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore settings on Object.prototype #4803
Ignore settings on Object.prototype #4803
Conversation
lib/router/layer.js
Outdated
*/ | ||
|
||
var hasOwnProperty = Object.prototype.hasOwnProperty; | ||
var hasOwnProperty = require('../utils').hasOwnProperty; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change isn't strictly related, but I figured we could use the new utility. Happy to revert.
No rush on my end, but let me know if you'd like me to do anything with this PR. |
5d0ff99
to
99043f5
Compare
99043f5
to
2ddae30
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you! i did end up removing the utils thing since we eventually want to get rid of utils and the only thing it was shared with, the router, was removed in 5.x anyway.
Before:
After:
See #4802 for more details.