Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: use cb() instead of done() #5233

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

kristof-low
Copy link
Contributor

I changed two uses of the done() callback to cb() since, as far as I can tell, this is what was intended.

Also, I changed the reassignment of the done() callback to creating a new cb() callback, since this is less confusing and more consistent with the rest of the tests.

If these changes are mistaken, please let me know.

dougwilson pushed a commit to kristof-low/express that referenced this pull request Sep 28, 2023
@dougwilson dougwilson merged commit 2a89eb5 into expressjs:master Feb 19, 2024
24 checks passed
@UlisesGascon UlisesGascon mentioned this pull request Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants