Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt Node@18 as the minimum supported version #5595

Merged
merged 4 commits into from
Sep 10, 2024

Conversation

UlisesGascon
Copy link
Member

As discussed in expressjs/discussions#224 and expressjs/discussions#196.

Here is a proposal to set Node@18 as the minimum version supported by Express v5.x

Main Changes

  • Set Node 18 as the minimum version in the package.json (4b3b8cc)
  • Remove from the CI any Node.js version prior to 18 (e9bcdd3)

Changelog

@wesleytodd
Copy link
Member

I had been thinking about this last night after our meeting and I was thinking that we should get all the dependencies working as we expect first and then do this specific change last. Maybe I am over thinking it, but I really do think it will be valuable to point specifically to the commits we landed which "broke" each node.js version. If we stop testing and do this early we loose that signal and it might be hard to untangle after the fact.

@UlisesGascon UlisesGascon self-assigned this Apr 11, 2024
@UlisesGascon
Copy link
Member Author

I had been thinking about this last night after our meeting and I was thinking that we should get all the dependencies working as we expect first and then do this specific change last.

AFAIK, there is no rush to merge this PR. It can be the last one before we officially release v5. Let's keep it open for a while and see how do we feel about it in few more commits 👍

@wesleytodd wesleytodd added the semver-major This change is a semver major label Apr 11, 2024
@wojtekmaj

This comment was marked as resolved.

@wesleytodd
Copy link
Member

We can remove them in an ad-hoc way. That is sort of why I am not sure this specific PR would be what we even land, but I don't see any reason not to keep it open for now until we are sure.

@jonchurch jonchurch requested a review from a team May 4, 2024 20:56
@jonchurch

This comment was marked as resolved.

@jonchurch jonchurch marked this pull request as draft May 4, 2024 22:19
@UlisesGascon UlisesGascon marked this pull request as ready for review May 5, 2024 15:22
@UlisesGascon UlisesGascon marked this pull request as draft May 5, 2024 15:22
@crandmck
Copy link
Member

crandmck commented May 6, 2024

So I think maybe the docs have gotten a bit ahead of ourselves here as we say 5.x requires Node 18+ ...
https://expressjs.com/en/5x/api.html

IIUC I think we do SUPPORT v18+ but technically we require a lower version. I probably changed this wording because I thought this was decided, my bad.

Probably not a huge deal since anyone who's using 5 has sorted this out... but if this isn't going to land soon, then should we say something different to be accurate?

@UlisesGascon
Copy link
Member Author

@crandmck you are right, the decision was made already (so in terms of documentation we are fine saying Node@18). This PR has moved to draft as we probably will merge it as the last one before releasing Express@5 ref

@RobinTail
Copy link
Contributor

we probably will merge it as the last one before releasing Express@5 ref

I recommend to do it now, @UlisesGascon .
This PR should be treated as a foundation of 5.x, because it enables using modern syntax, latest dependencies and to remove various compatibility crutches in all other PRs.

@UlisesGascon
Copy link
Member Author

based on the CI output, should we skip this tests in 21? Due the known QUERY issue.

Screenshot from 2024-07-26 12-06-59

@wesleytodd
Copy link
Member

This is what @ctcpip was hoping to fix with merging the 4.x branch which has a change to skip that QUERY test. We could also consider cherry-picking that commit over if we want to fix it sooner than the next release of v4.

@wesleytodd wesleytodd mentioned this pull request Jul 26, 2024
@RobinTail

This comment was marked as spam.

@UlisesGascon
Copy link
Member Author

This PR is now closed as #5803 was merged including this change 🥳

@ctcpip ctcpip reopened this Aug 2, 2024
@ctcpip
Copy link
Member

ctcpip commented Aug 2, 2024

reopened. I think some wires got crossed here

@ctcpip
Copy link
Member

ctcpip commented Aug 2, 2024

we wanted these changes in the master->5.0 merge branch/PR, so we pulled them in. therefore, merging that PR will resolve this one.

edit: converting this to draft so we don't accidentally merge it, but all the commits here have been pulled into the merge branch

@ctcpip ctcpip marked this pull request as draft August 2, 2024 21:26
@RobinTail
Copy link
Contributor

RobinTail commented Aug 3, 2024

This PR is needed to remove the redundant pipelines that are still running and failing in the 5.0 branch against the unsupported engines.

node-version: [18, 19, 20, 21, 22]

Without it you will keep having a yearly supply of red crosses in every PR targeting 5.0:

image

@wesleytodd wesleytodd merged commit 63992bb into expressjs:5.0 Sep 10, 2024
13 of 14 checks passed
Bbjj88h

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5.x semver-major This change is a semver major
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants