Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skip QUERY tests for Node 21 only, still not supported #5695

Merged
merged 4 commits into from
Jun 9, 2024
+12 −11
Merged

skip QUERY tests for Node 21 only, still not supported #5695

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
13e7fb4
skip QUERY tests for Node 21 only, still not supported
jonchurch Jun 5, 2024
4474718
update CI to run on 21.7 and 22.2
jonchurch Jun 5, 2024
9d3bcfe
update query test to actually skip, simplify shouldSkipQuery
jonchurch Jun 8, 2024
fcf7ca6
remove skip message, doesn't seem to work
jonchurch Jun 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,10 +134,10 @@ jobs:
node-version: "20.11"

- name: Node.js 21.x
node-version: "21.6"
node-version: "21.7"

- name: Node.js 22.x
node-version: "22.0"
node-version: "22.2"

steps:
- uses: actions/checkout@v4
Expand Down
8 changes: 4 additions & 4 deletions test/support/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,12 +77,12 @@ function getMajorVersion(versionString) {
}

function shouldSkipQuery(versionString) {
// Temporarily skipping this test on 22
// update this implementation to run on those release lines on supported versions once they exist
// upstream tracking https://github.com/nodejs/node/pull/51719
// Skipping HTTP QUERY tests on 21, it is reported in http.METHODS on 21.7.2 but not supported
// update this implementation to run on supported versions of 21 once they exist
// upstream tracking https://github.com/nodejs/node/issues/51562
// express tracking issue: https://github.com/expressjs/express/issues/5615
var majorsToSkip = {
"22": true
"21": true
}
return majorsToSkip[getMajorVersion(versionString)]
}
Expand Down
Loading