Skip to content

docs: update Contributing.md to clarify repo captain permissions #6357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

docs: update Contributing.md to clarify repo captain permissions #6357

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Contributing.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ active member steps down.
The Express TC can designate captains for individual projects/repos in the
organizations. These captains are responsible for being the primary
day-to-day maintainers of the repo on a technical and community front.
Repo captains are empowered with repo ownership and package publication rights.
Repo captains are empowered with maintain access and package publication rights.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand that only the TCs can have admin rights, but when it comes to security reports, with maintainer rights, it is not possible to publish or review those reports on GitHub. There are quite a few limitations with those permissions.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that this is intentional. Security reports should come through the security triage team first and the repo captains should be looped in once the initial triage has happened. So they would be individually added to applicable security issues/pr's/private forks.

Maybe I am wrong on that though? cc @UlisesGascon @ctcpip

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-posting this comment here:

We might also want to say "Repo captians are empowered to maintain the project with the repo maintain role and pacakge publication rights."?

#6477 (comment)

When there are conflicts, especially on topics that effect the Express project
at large, captains are responsible to raise it up to the TC and drive
those conflicts to resolution. Captains are also responsible for making sure
Expand Down