Document path to regexp migration #1317
Conversation
|
See the original version of this pull request if you need more context: #1316 |
|
@dougwilson @crandmck The migration guide is translated into other languages. Can you let me know the process for handling the translated versions? |
|
Hi @euoia sorry for the delay. I will take a read through this, but first just wanted to respond to your question: Translation is now only handled by community members who lend a hand; we no longer have a professional translation service. If the English page changes enough to make the translated page misleading or such, we can just delete it so that lanage sees the English version until someone translates it again. |
dougwilson
force-pushed
the
gh-pages
branch
2 times, most recently
from
1fd61c6 to
ef068f8
Compare
crandmck
added
the
needs tech review
|
Something very similar was done in https://expressjs.com/en/guide/migrating-5.html so this probably isn't needed any more. The only diff is that this has And we currently have In practice, I think they're equivalent, but I'm no expert on npm versioning expressions. |
|
cc @blakeembrey, is this accurate so far as you know? |
|
@jonchurch Accurate, although I intend to re-add |
|
Sorry to be dense, but can you clarify which you prefer for "Upgrading to 5.x" in the doc?
|
|
Closed in favor of #1610 |
* add `res.query` and `res.redirect`
* add `express.urlencoded` and `req.body`
* add `res.clearCookie` and `res.status`
* update introduction page
* add `res.redirect('back')` and `res.location('back')`
* bring changes from #1317
* add `brotli` support
* adapt router matching syntax
* add `res.query` and `res.redirect`
* add `express.urlencoded` and `req.body`
* add `res.clearCookie` and `res.status`
* update introduction page
* add `res.redirect('back')` and `res.location('back')`
* bring changes from expressjs#1317
* add `brotli` support
* adapt router matching syntax
Add documentation based on the updates to path-to-regexp in https://github.com/pillarjs/router/pull/102/files.
I also took the opportunity to simplify the intro and remove references to "alpha". I'm happy to revert or extract these to a separate pull request if it's more appropriate.