Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update res-render.md #1441

Merged
merged 2 commits into from
Mar 6, 2024
Merged

Update res-render.md #1441

merged 2 commits into from
Mar 6, 2024

Conversation

zareefhasan
Copy link
Contributor

Using template engine link was redirecting to Turkish page buy default. Changing it to English version page.

Using template engine link was redirecting to Turkish page buy default. Changing it to English version page.
_includes/api/en/5x/res-render.md Outdated Show resolved Hide resolved
@crandmck
Copy link
Member

crandmck commented Mar 5, 2024

@zareefhasan If you will make this change, we can land this PR. Thanks.

Co-authored-by: Ulises Gascón <ulisesgascongonzalez@gmail.com>
@jonchurch
Copy link
Member

Im not able to repro the turkish redirect. But I do think the convention is that for links off-page we should use pageLang to make sure the link is correct.

@jonchurch jonchurch requested a review from UlisesGascon March 5, 2024 23:32
@crandmck crandmck merged commit b15a296 into expressjs:gh-pages Mar 6, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants