Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added job level permissions in .github/workflows/translation.yml #1557

Merged
merged 2 commits into from
Aug 13, 2024

Conversation

IamLizu
Copy link
Member

@IamLizu IamLizu commented Aug 2, 2024

As seen in #1552, translation.yml fails to add labels to PR due to permissions.

  • Added appropriate permissions for the check-translation job.
  • Called github.rest.issues.addLabels() when labelsToAdd is not empty.

Notes

Copy link

netlify bot commented Aug 2, 2024

Deploy Preview for expressjscom-preview failed.

Name Link
🔨 Latest commit c9604f9
🔍 Latest deploy log https://app.netlify.com/sites/expressjscom-preview/deploys/66b73780539cf200087194ca

@IamLizu IamLizu force-pushed the fix/translation.yml branch from 0ca7509 to c9604f9 Compare August 10, 2024 09:48
Copy link
Member

@UlisesGascon UlisesGascon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @IamLizu! I will merge the PR 👍

@UlisesGascon UlisesGascon merged commit 57799ec into expressjs:gh-pages Aug 13, 2024
2 of 6 checks passed
@UlisesGascon
Copy link
Member

It is working again! https://github.com/expressjs/expressjs.com/actions/runs/10365067435/job/28691503034. Thanks a lot @IamLizu

@IamLizu
Copy link
Member Author

IamLizu commented Aug 13, 2024

Hey @UlisesGascon, I am happy to help <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"RequestError [HttpError]: Resource not accessible by integration" for .github/workflows /translation.yml
2 participants