Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Version Support page and Commercial Support Options #1585

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

ljharb
Copy link
Contributor

@ljharb ljharb commented Aug 28, 2024

Main Changes

  • Added support page (including link in the navbar)
  • Added banner on the deprecated APIs documentation

Context

Related to expressjs/discussions#257

Details

Support page

Preview: https://deploy-preview-1585--expressjscom-preview.netlify.app/en/support/

Screenshot 2024-08-27 at 6 00 43 PM

Banner

Preview: https://deploy-preview-1585--expressjscom-preview.netlify.app/en/3x/api

Screenshot 2024-08-27 at 5 59 51 PM

Verified

This commit was signed with the committer’s verified signature.
ljharb Jordan Harband

This comment was marked as off-topic.

@UlisesGascon
Copy link
Member

Thanks for the PR @ljharb, I made some changes on the description.

BTW the CI failing error is not related to this PR.

@UlisesGascon UlisesGascon requested a review from a team August 28, 2024 09:07
Copy link
Member

@sheplu sheplu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@wesleytodd wesleytodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we might want to nail down some of the LTS plans before we land this, but I am good with the changes here.

@ljharb ljharb requested a review from ctcpip August 28, 2024 19:22
@ljharb ljharb requested a review from ctcpip August 28, 2024 21:16
@ljharb ljharb requested a review from ctcpip August 29, 2024 18:05
Copy link
Member

@ctcpip ctcpip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wesleytodd if we want to wait to land this, we should convert to draft

@UlisesGascon
Copy link
Member

I will land it, seems like we are align with the changes. We can always open an additional PR to make more changes if needed :)

@UlisesGascon UlisesGascon merged commit 8e111ba into expressjs:gh-pages Aug 30, 2024
6 of 7 checks passed
@ljharb ljharb deleted the support-page branch August 30, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants